linux-kernel - Re: [PATCH 5/5] powerpc: use asm-generic/dma-mapping-common.h

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20090728145138Y.fujita.tomonori@lab.ntt.co.jp>
Date:	Tue, 28 Jul 2009 14:54:58 +0900
From:	FUJITA Tomonori <fujita.tomonori@....ntt.co.jp>
To:	beckyb@...nel.crashing.org, benh@...nel.crashing.org
Cc:	fujita.tomonori@....ntt.co.jp, linuxppc-dev@...ts.ozlabs.org,
	galak@...nel.crashing.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 5/5] powerpc: use asm-generic/dma-mapping-common.h

On Mon, 27 Jul 2009 16:08:46 -0500
Becky Bruce <beckyb@...nel.crashing.org> wrote:

> 
> On Jul 23, 2009, at 10:24 PM, FUJITA Tomonori wrote:
> 
> > Signed-off-by: FUJITA Tomonori <fujita.tomonori@....ntt.co.jp>
> 
> Fujita,
> 
> Since you're removing all the uses of it, you should probably remove  
> PPC_NEED_DMA_SYNC_OPS from arch/powerpc/Kconfig:
> 
> diff --git a/arch/powerpc/Kconfig b/arch/powerpc/Kconfig
> index 0603b6c..fb3f4ff 100644
> --- a/arch/powerpc/Kconfig
> +++ b/arch/powerpc/Kconfig
> @@ -307,10 +307,6 @@ config SWIOTLB
>            platforms where the size of a physical address is larger
>            than the bus address.  Not all platforms support this.
> 
> -config PPC_NEED_DMA_SYNC_OPS
> -       def_bool y
> -       depends on (NOT_COHERENT_CACHE || SWIOTLB)
> -
>   config HOTPLUG_CPU
>          bool "Support for enabling/disabling CPUs"
>          depends on SMP && HOTPLUG && EXPERIMENTAL && (PPC_PSERIES ||  
> PPC_PMAC)
> 
> Otherwise, this looks good to me.

Ah, thanks. I fold the above change. The updated patchset is available
at:

git://git.kernel.org/pub/scm/linux/kernel/git/tomo/linux-2.6-misc.git powerpc


> I also think you want an ACK from Ben - making this switch does add  
> slight overhead to platforms that don't need sync ops, but I think  
> it's worth it.  IIRC, it was Ben who asked for the optimization of  
> NEED_DMA_SYNC_OPS, so I'd like him to weigh in here.

Yeah, of course. Ben?
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/