linux-kernel - fbmon.c: err not needed in edid

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-Id: <200907291030.03277.toralf.foerster@gmx.de>
Date:	Wed, 29 Jul 2009 10:30:03 +0200
From:	Toralf Förster <toralf.foerster@....de>
To:	linux-fbdev-devel@...ts.sourceforge.net
Cc:	linux-kernel@...r.kernel.org
Subject: fbmon.c: err not needed in edid_checksum()

IMO that variable isn't needed.

Signed-off-by: Toralf Foerster <toralf.foerster@....de>
---
drivers/video/fbmon.c |    6 +++---
 1 files changed, 3 insertions(+), 3 deletions(-)

diff --git a/drivers/video/fbmon.c b/drivers/video/fbmon.c
index e1b7073..cea7561 100644
--- a/drivers/video/fbmon.c
+++ b/drivers/video/fbmon.c
@@ -257,7 +257,7 @@ static void fix_edid(unsigned char *edid, int fix)
 static int edid_checksum(unsigned char *edid)
 {
 	unsigned char csum = 0, all_null = 0;
-	int i, err = 0, fix = check_edid(edid);
+	int i, fix = check_edid(edid);
 
 	if (fix)
 		fix_edid(edid, fix);
@@ -269,10 +269,10 @@ static int edid_checksum(unsigned char *edid)
 
 	if (csum == 0x00 && all_null) {
 		/* checksum passed, everything's good */
-		err = 1;
+		return 1;
 	}
 
-	return err;
+	return 0;
 }
 
 static int edid_check_header(unsigned char *edid)

-- 
MfG/Sincerely

Toralf Förster
pgp finger print: 7B1A 07F4 EC82 0F90 D4C2 8936 872A E508 7DB6 9DA3

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/