linux-kernel - Re: [PATCH] tracing: stack allocation fix

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <alpine.DEB.2.00.0907290926570.8471@gandalf.stny.rr.com>
Date:	Wed, 29 Jul 2009 09:27:29 -0400 (EDT)
From:	Steven Rostedt <rostedt@...dmis.org>
To:	Jiri Olsa <jolsa@...hat.com>
cc:	Ingo Molnar <mingo@...e.hu>, lkml <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] tracing: stack allocation fix


On Wed, 29 Jul 2009, Jiri Olsa wrote:

> Only 24 bytes need to be allocated.
> 
> I believe this was missed in following commit:
> x86, function-graph: only save return values on x86_64
> commit e71e99c294058a61b7a8b9bb6da2f745ac51aa4f

I was just being paranoid again. But it still worked. I'll take this patch 
as a clean up.

Thanks!

-- Steve


> 
> wbr,
> jirka
> 
> 
> Signed-off-by: Jiri Olsa <jolsa@...hat.com>
> 
> ---
> diff --git a/arch/x86/kernel/entry_64.S b/arch/x86/kernel/entry_64.S
> index c251be7..d59fe32 100644
> --- a/arch/x86/kernel/entry_64.S
> +++ b/arch/x86/kernel/entry_64.S
> @@ -146,7 +146,7 @@ ENTRY(ftrace_graph_caller)
>  END(ftrace_graph_caller)
>  
>  GLOBAL(return_to_handler)
> -	subq  $80, %rsp
> +	subq  $24, %rsp
>  
>  	/* Save the return values */
>  	movq %rax, (%rsp)
> @@ -155,10 +155,10 @@ GLOBAL(return_to_handler)
>  
>  	call ftrace_return_to_handler
>  
> -	movq %rax, 72(%rsp)
> +	movq %rax, 16(%rsp)
>  	movq 8(%rsp), %rdx
>  	movq (%rsp), %rax
> -	addq $72, %rsp
> +	addq $16, %rsp
>  	retq
>  #endif
>  
> 
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/