linux-kernel - Re: [PATCH] dmaengine: at_hdmac: add DMA slave transfers

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <4A705C6F.1000203@intel.com>
Date:	Wed, 29 Jul 2009 07:27:59 -0700
From:	Dan Williams <dan.j.williams@...el.com>
To:	Atsushi Nemoto <anemo@....ocn.ne.jp>
CC:	"Sosnowski, Maciej" <maciej.sosnowski@...el.com>,
	"haavard.skinnemoen@...el.com" <haavard.skinnemoen@...el.com>,
	"nicolas.ferre@...el.com" <nicolas.ferre@...el.com>,
	"linux-arm-kernel@...ts.arm.linux.org.uk" 
	<linux-arm-kernel@...ts.arm.linux.org.uk>,
	"patrice.vilchez@...el.com" <patrice.vilchez@...el.com>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] dmaengine: at_hdmac: add DMA slave transfers

Atsushi Nemoto wrote:
> On Mon, 27 Jul 2009 14:24:26 +0100, "Sosnowski, Maciej" <maciej.sosnowski@...el.com> wrote:
>>>> Your atc_chain_complete() calls dma_unmap_xxx unless
>>>> DMA_COMPL_SKIP_XXX_UNMAP specified.  But atmel-mci driver does not set
>>>> the flag on dma_async_tx_descriptor.  I suppose one of them should be
>>>> fixed.
>>> atmel-mci should definitely set that flag.
>>>
>>> Haavard
>> I agree with Haavard.
> 
> Then, what should dma driver do when client driver did not set these
> flags?  If it should call dma_unmap_sg(), the dma driver should keep
> sg and direction somewhere...
> 
> Also, calling dma_map_sg() in its prep_slave_sg function will not fit
> for sound drivers, which use DMA buffers prepared in its framework.
> 
> For slave DMA, doing all mapping/unmapping in DMA client is better,
> isn't it?
> 

Yes it is.  The whole point of the dma driver doing its own unmapping is 
specifically for clients that use the async_tx api, i.e. where they do 
not know if the transaction is carried out in hardware and have no way 
of tracking the details necessary to perform the unmap.  DMA-slave 
clients request specific channels and know the hardware details at a low 
level, so it should not be too high an expectation to push dma mapping 
responsibility to the client.

--
Dan
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/