linux-kernel - Re: [RFC][patch 02/12] remove clocksource inline functions

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-ID: <20090729164411.6d7bd9f6@skybase>
Date:	Wed, 29 Jul 2009 16:44:11 +0200
From:	Martin Schwidefsky <schwidefsky@...ibm.com>
To:	dwalker@...o99.com
Cc:	linux-kernel@...r.kernel.org, Ingo Molnar <mingo@...e.hu>,
	Thomas Gleixner <tglx@...utronix.de>,
	john stultz <johnstul@...ibm.com>
Subject: Re: [RFC][patch 02/12] remove clocksource inline functions

On Wed, 29 Jul 2009 08:15:19 -0600
dwalker@...o99.com wrote:

> > Remove clocksource_read, clocksource_enable and clocksource_disable
> > inline functions. No functional change.
> > 
> 
> Your still not really explaining this one, is this suppose to be
> cleaner? Or is this related to some other part of your clean up?

The only one of the three inline functions that is a bit more
complicated is clocksource_enable() because of the mult_orig logic. But
that goes away with a later patch. The function aren't accessors either,
they are used exclusively by the timekeeping code. In short, they are
useless, don't you think?

-- 
blue skies,
   Martin.

"Reality continues to ruin my life." - Calvin.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/