linux-kernel - Re: [RFC][patch 02/12] remove clocksource inline functions

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <87a5b0800907290836n6bb6da36tb0124e6d4f0673ea@mail.gmail.com>
Date:	Wed, 29 Jul 2009 16:36:46 +0100
From:	Will Newton <will.newton@...il.com>
To:	Martin Schwidefsky <schwidefsky@...ibm.com>
Cc:	dwalker@...o99.com, linux-kernel@...r.kernel.org,
	Ingo Molnar <mingo@...e.hu>,
	Thomas Gleixner <tglx@...utronix.de>,
	john stultz <johnstul@...ibm.com>
Subject: Re: [RFC][patch 02/12] remove clocksource inline functions

On Wed, Jul 29, 2009 at 4:32 PM, Martin
Schwidefsky<schwidefsky@...ibm.com> wrote:

> Hmm, you have an object of type struct clocksource and you do
> cs->read(cs). If that is not clear enough then I don't know what is. We
> do that all over the place in the linux kernel. And I personally find
> these useless wrappers rather annoying. I don't like to have to jump to
> another place to find out that it just calls the read function of the
> object.

An argument for the helper is that it eases grepability. Sure you can
search for "->read" but that's going to turn up all kinds of
non-clocksource code as well. grep clocksource_read will get you
exactly what you want.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/