linux-kernel - Re: Missing device IDs in rt2870

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20090729161643.GA6313@suse.de>
Date:	Wed, 29 Jul 2009 09:16:43 -0700
From:	Greg KH <gregkh@...e.de>
To:	Jakob Gruber <jakob.gruber@...elnet.at>
Cc:	linux-kernel@...r.kernel.org
Subject: Re: Missing device IDs in rt2870

On Wed, Jul 29, 2009 at 05:11:07PM +0200, Jakob Gruber wrote:
> On Tue, 28 Jul 2009 14:12:16 -0700
> Greg KH <gregkh@...e.de> wrote:
> 
> > On Tue, Jul 28, 2009 at 11:01:17PM +0200, Jakob Gruber wrote:
> > > >From http://bugzilla.kernel.org/show_bug.cgi?id=13459#c3
> > > 
> > > In rt2870.h, there are 2 lists of USB devices. One is within 
> > > 
> > > #ifndef RT30xx
> > > #endif
> > > 
> > > and the other in 
> > > 
> > > #ifdef RT30xx
> > > #endif
> > 
> > That kind of implies that the 2870 driver should not support this
> > device, right?
> 
> I think there's been a misunderstanding - I wasn't saying that the
> device ID is included in one block but not in another. I wanted to
> point out that I wasn't sure whether to add the ID to both lists or
> just the first one.

Ah, ok.  It looks like you just need the first one.

> > > Since I'm not sure whether to add the devices to both lists or only the first,
> > > I'm posting a patch for both variations.
> > > 
> > > Patch 1, add devices only to first list:
> > 
> > Well, pick one :)
> > 
> > I'd prefer someone with one of these devices to test the patch and
> > verify that it works before blindly applying.  Fair enough?
> 
> I own the Belkin device in question (0x050D,0x815C), and it worked
> perfectly with kernel 2.6.29 after adding the device ID to rt2870.h.
> The patch is also included in the Archlinux kernel, see 
> http://projects.archlinux.org/?p=linux-2.6-ARCH.git;a=tree;f=patches;hb=HEAD
> 
> I haven't tested rt2870 in 2.6.30 thoroughly because of this bug
> (http://bugzilla.kernel.org/show_bug.cgi?id=13638), which forces me to
> use the driver from the Ralink website instead of the kernel module.
> However, I can confirm that - until running into the bug - the Belkin
> card also works in 2.6.30. 

Ah, that sucks.  I should revert that patch, if you do that, does the
device work properly for you?

> A patch for adding the Belkin device ID is attached. I removed the
> other 2 IDs from http://bugzilla.kernel.org/show_bug.cgi?id=13459
> since I do not own these devices and cannot verify them. The ID is
> only added to the "#ifndef RT30xx" block, same as the patch applied to
> the Archlinux kernel.

I'll take the other two ids, now that it makes more sense.

Care to respin with the 2 new ids, and add a "Signed-off-by:" to the
patch so I can properly apply it?

thanks,

greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/