linux-kernel - Re: [PATCH] kdesu broken

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-id: <200907291443.13983.gene.heskett@verizon.net>
Date:	Wed, 29 Jul 2009 14:43:13 -0400
From:	Gene Heskett <gene.heskett@...izon.net>
To:	Frans Pop <elendil@...net.nl>
Cc:	alan@...rguk.ukuu.org.uk, torvalds@...ux-foundation.org,
	hirofumi@...l.parknet.co.jp, aneesh.kumar@...ux.vnet.ibm.com,
	rjw@...k.pl, ray-lk@...rabbit.org, linux-kernel@...r.kernel.org,
	akpm@...ux-foundation.org, stern@...land.harvard.edu
Subject: Re: [PATCH] kdesu broken

On Wednesday 29 July 2009, Frans Pop wrote:
>> What is needed for a mistake free bisect is a 'doesn't matter as long
>> as it matches' Makefile version that survives all the way through a
>> bisect run.
>
>I have a wrapper script I use for kernel builds that takes care of that
>(it also supports cross building and building some out-of-tree modules).
>Some snippets from that script below.
>
>BISECTING=
>if [ -e .git/BISECT_LOG ]; then
>        BISECTING=1
>fi
>[...]
>if [ "$BISECTING" ]; then
>        # The version in the next line may need updating before a bisect
>        sed -i "s/^SUBLEVEL = .*/SUBLEVEL = 31/" Makefile
>        sed -i "s/^EXTRAVERSION =.*/EXTRAVERSION = -bisect/" Makefile
>fi
>[...]
>make ...
>[...]
>if [ "$BISECTING" ]; then
>	# Revert Makefile to avoid errors on 'git bisect good/bad'
>        git checkout Makefile
Ahh, I see that now, which I was objecting to below.  I'll go quietly. :)
>fi
>
>I use the deb-pkg target and also set the .deb package version in the
>second hunk:
>KERNELDEBREVISION=$(grep "^git[- ]bisect" .git/BISECT_LOG | wc -l)
>
>This way I end up with a nice series of packages whose numbering matches
>the steps in .git/BISECT_LOG:
>linux-image-2.6.31-bisect_1_amd64.deb
>linux-image-2.6.31-bisect_2_amd64.deb
>linux-image-2.6.31-bisect_3_amd64.deb
>...
>
>Hope that help.
>
>Cheers,
>FJP

Yes, some of it will.  But thanks to fedora's broken disk partitioner, 
something I've been screaming about for a damned decade, my /boot partition 
isn't big enough to absorb a whole chain of those, hence the fixed version 
request.

This script would appear to need a restore function for the Makefile version 
because one of my 'git bisect bad's returned that it couldn't switch branches 
because of the handmade Makefile changes I'd done on the first build.  How 
have you been handling that?

-- 
Cheers, Gene
"There are four boxes to be used in defense of liberty:
 soap, ballot, jury, and ammo. Please use in that order."
-Ed Howdershelt (Author)
The NRA is offering FREE Associate memberships to anyone who wants them.
<https://www.nrahq.org/nrabonus/accept-membership.asp>

When you don't know what to do, walk fast and look worried.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/