[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-Id: <20090729213756.D23EF526EC9@mailhub.coreip.homeip.net>
Date: Wed, 29 Jul 2009 14:03:55 -0700
From: Dmitry Torokhov <dmitry.torokhov@...il.com>
To: "Rafael J. Wysocki" <rjw@...k.pl>
Cc: Arnaud Faucher <arnaud.faucher@...il.com>,
Carlos Corbacho <carlos@...angeworlds.co.uk>,
"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
Frans Pop <elendil@...net.nl>,
Manuel Lauss <manuel.lauss@...il.com>,
Erik Ekman <erik@...o.se>,
Mark Brown <broonie@...nsource.wolfsonmicro.com>
Subject: Re: [PATCH 1/1] acer-wmi: switch driver to dev_pm_ops
On Wed, Jul 29, 2009 at 10:49:46PM +0200, Rafael J. Wysocki wrote:
> On Wednesday 29 July 2009, Arnaud Faucher wrote:
>
> > As per the pm.h documentation .thaw is called after RAM image has been
> > created, in order to restore hardware state in case RAM image failed and
> > the system cannot power off.
>
> That's not correct (please see above). .thaw() is called after creating the
> image in case .freeze() has changed the state of the device. This often is not
> necessary, though, so .thaw() may be skipped in many cases. Of course, you
> should know exactly what you're doing.
>
Umm, but thaw() _is_ called in case of hibernate failure:
case PM_EVENT_THAW:
case PM_EVENT_RECOVER:
if (ops->thaw) {
error = ops->thaw(dev);
suspend_report_result(ops->thaw, error);
}
break;
so I don't believe you can easily skip thaw() if you have freeze() that
stops/resets device.
--
Dmitry
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists