linux-kernel - Re: [PATCH] missing mutex unlock

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20090730110048.GA24094@2ka.mipt.ru>
Date:	Thu, 30 Jul 2009 15:00:52 +0400
From:	Evgeniy Polyakov <johnpol@....mipt.ru>
To:	Stoyan Gaydarov <sgayda2@...c.edu>
Cc:	linux-kernel@...r.kernel.org, akpm@...ux-foundation.org,
	stanley.miao@...driver.com, rmk+kernel@....linux.org.uk,
	madhu.cr@...com, felipe.balbi@...ia.com
Subject: Re: [PATCH] missing mutex unlock

On Thu, Jul 30, 2009 at 04:57:18AM -0500, Stoyan Gaydarov (sgayda2@...c.edu) wrote:
> This was found using a semantic patch, more info can be found at:
> http://www.emn.fr/x-info/coccinelle/
> 
> Signed-off-by: Stoyan Gaydarov <sgayda2@...c.edu>

Yup, that's correct.
Ack, thank you.

Andrew, please apply.

> ---
>  drivers/w1/masters/omap_hdq.c |    1 +
>  1 files changed, 1 insertions(+), 0 deletions(-)
> 
> diff --git a/drivers/w1/masters/omap_hdq.c b/drivers/w1/masters/omap_hdq.c
> index a7e3b70..0d92969 100644
> --- a/drivers/w1/masters/omap_hdq.c
> +++ b/drivers/w1/masters/omap_hdq.c
> @@ -687,6 +687,7 @@ static int omap_hdq_remove(struct platform_device *pdev)
>  
>  	if (hdq_data->hdq_usecount) {
>  		dev_dbg(&pdev->dev, "removed when use count is not zero\n");
> +		mutex_unlock(&hdq_data->hdq_mutex);
>  		return -EBUSY;
>  	}
>  
> -- 
> 1.6.3.3
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/