| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Message-Id: <200907301312.48132.bzolnier@gmail.com> Date: Thu, 30 Jul 2009 13:12:47 +0200 From: Bartlomiej Zolnierkiewicz <bzolnier@...il.com> To: Jonathan Woithe <jwoithe@...sics.adelaide.edu.au> Cc: linux-acpi@...r.kernel.org, linux-kernel@...r.kernel.org, Dan Carpenter <error27@...il.com>, corbet@....net, eteo@...hat.com, Julia Lawall <julia@...u.dk> Subject: Re: [PATCH] fujitsu-laptop: remove superfluous NULL pointer checks Hi, On Thursday 30 July 2009 09:43:49 Jonathan Woithe wrote: > Hi Bart > > > From: Bartlomiej Zolnierkiewicz <bzolnier@...il.com> > > Subject: [PATCH] fujitsu-laptop: remove superfluous NULL pointer checks > > > > This takes care of the following entries from Dan's list: > > > > drivers/platform/x86/fujitsu-laptop.c +327 set_lcd_level(13) warning: variable derefenced before check 'fujitsu' > > drivers/platform/x86/fujitsu-laptop.c +358 set_lcd_level_alt(13) warning: variable derefenced before check 'fujitsu' > > I'd rather keep the test for a non-null fujitsu in there, but obviously it's > kind of pointless doing it after the first dereference. Since this fixup > overlaps with the one previously discussed with Julia I've taken the liberty They are on top of Julia's patch (sorry I forgot to mention it).. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists