linux-kernel - Re: linux-next: scsi-rc-fixes tree build failure

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <1248961882.3880.4.camel@mulgrave.site>
Date:	Thu, 30 Jul 2009 08:51:22 -0500
From:	James Bottomley <James.Bottomley@...senPartnership.com>
To:	Stephen Rothwell <sfr@...b.auug.org.au>
Cc:	linux-next@...r.kernel.org, linux-kernel@...r.kernel.org,
	Tom Peng <tom_peng@...sh.com>, Jack Wang <jack_wang@...sh.com>,
	Lindar Liu <lindar_liu@...sh.com>,
	Kevin Ao <aoqingyun@...sh.com>,
	linux-scsi <linux-scsi@...r.kernel.org>
Subject: Re: linux-next: scsi-rc-fixes tree build failure

On Thu, 2009-07-30 at 18:13 +1000, Stephen Rothwell wrote:
> Hi James,
> 
> Today's linux-next build (powerpc allyesconfig) failed like this:
> 
> drivers/scsi/libsas/sas_expander.c: In function 'sas_find_bcast_dev':
> drivers/scsi/libsas/sas_expander.c:1701: error: 'FALSE' undeclared (first use in this function)
> drivers/scsi/libsas/sas_expander.c: In function 'sas_discover_new':
> drivers/scsi/libsas/sas_expander.c:1809: error: 'FALSE' undeclared (first use in this function)
> drivers/scsi/libsas/sas_expander.c:1824: error: 'TRUE' undeclared (first use in this function)
> drivers/scsi/libsas/sas_expander.c: In function 'sas_rediscover':
> drivers/scsi/libsas/sas_expander.c:1903: error: 'TRUE' undeclared (first use in this function)
> drivers/scsi/libsas/sas_expander.c:1918: error: 'FALSE' undeclared (first use in this function)
> drivers/scsi/libsas/sas_expander.c: In function 'sas_ex_revalidate_domain':
> drivers/scsi/libsas/sas_expander.c:1951: error: 'TRUE' undeclared (first use in this function)
> 
> Caused by commit 4c70d933a41e1d712f3db90d2a41141730383d5a ("[SCSI]
> libsas: fix wide port hotplug issues").  Presumably a missing include
> file.

Actually, I don't think so.  It's confusion over the use of boolean
variables.  I think they have to be set to lower case true, false, not
upper case.  There's obviously some accidental definition of TRUE and
FALSE in x86.

> I have reverted that commit for today.

Thanks, I've dropped it from my tree ... I'll put it back when this is
sorted out.

James


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/