linux-kernel - Re: [PATCH 4/5] net/netlabel: Add kmalloc NULL tests

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <Pine.LNX.4.64.0907301636280.8734@ask.diku.dk>
Date:	Thu, 30 Jul 2009 16:36:47 +0200 (CEST)
From:	Julia Lawall <julia@...u.dk>
To:	Paul Moore <paul.moore@...com>
Cc:	netdev@...r.kernel.org, linux-kernel@...r.kernel.org,
	kernel-janitors@...r.kernel.org
Subject: Re: [PATCH 4/5] net/netlabel: Add kmalloc NULL tests

On Thu, 30 Jul 2009, Paul Moore wrote:

> On Thursday 30 July 2009 10:10:54 am Julia Lawall wrote:
> > From: Julia Lawall <julia@...u.dk>
> >
> > The test on map4 should be a test on map6.
> 
> ...
> 
> > Signed-off-by: Julia Lawall <julia@...u.dk>
> >
> > ---
> >  net/netlabel/netlabel_kapi.c        |    2 +-
> >  1 files changed, 1 insertions(+), 1 deletions(-)
> >
> > diff --git a/net/netlabel/netlabel_kapi.c b/net/netlabel/netlabel_kapi.c
> > index 3ff6f32..6ce0020 100644
> > --- a/net/netlabel/netlabel_kapi.c
> > +++ b/net/netlabel/netlabel_kapi.c
> > @@ -151,7 +151,7 @@ int netlbl_cfg_unlbl_map_add(const char *domain,
> >  			addr6 = addr;
> >  			mask6 = mask;
> >  			map6 = kzalloc(sizeof(*map6), GFP_ATOMIC);
> > -			if (map4 == NULL)
> > +			if (!map6)
> >  				goto cfg_unlbl_map_add_failure;
> >  			map6->type = NETLBL_NLTYPE_UNLABELED;
> >  			ipv6_addr_copy(&map6->list.addr, addr6);
> 
> Another good find, although I would suggest changing it to the following to 
> stay consistent with the rest of the function:
> 
> 		map6 = kzalloc(...);
> 		if (map6 == NULL)
> 			goto ...;

OK, I hesitated...  I'll send a new patch shortly.

julia
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/