linux-kernel - Re: [Patch RFC 21/37] affs: use semaphore_init instead of init

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20090730211453.GB14722@infradead.org>
Date:	Thu, 30 Jul 2009 17:14:53 -0400
From:	Christoph Hellwig <hch@...radead.org>
To:	Thomas Gleixner <tglx@...utronix.de>
Cc:	LKML <linux-kernel@...r.kernel.org>,
	Andrew Morton <akpm@...ux-foundation.org>,
	Ingo Molnar <mingo@...e.hu>,
	Peter Zijlstra <peterz@...radead.org>,
	Al Viro <viro@...iv.linux.org.uk>
Subject: Re: [Patch RFC 21/37] affs: use semaphore_init instead of
	init_MUTEX

On Sun, Jul 26, 2009 at 08:18:45AM -0000, Thomas Gleixner wrote:
> The usage of these "mutex" is non obvious and probably a completion
> in some places. Make it them semaphores.

Except for the obsfucation by the wrappers it's clearly obvious that
these are plain binary mutexes, so they should be converted.  Note that
this will trigger some lockdep warnings as we sometimes hold the same
lock for parent and child.  Maybe we can use this as a check if any
users of affs are left :)

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/