linux-kernel - Re: [PATCH v2 2/2] IPVS: use pr_err and friends instead of IP_VS

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20090730.142906.266849967.davem@davemloft.net>
Date:	Thu, 30 Jul 2009 14:29:06 -0700 (PDT)
From:	David Miller <davem@...emloft.net>
To:	joe@...ches.com
Cc:	heder@...gle.com, lvs-devel@...r.kernel.org,
	netdev@...r.kernel.org, linux-kernel@...r.kernel.org,
	jengelh@...ozas.de
Subject: Re: [PATCH v2 2/2] IPVS: use pr_err and friends instead of
 IP_VS_ERR and friends

From: Joe Perches <joe@...ches.com>
Date: Tue, 28 Jul 2009 13:56:55 -0700

> On Tue, 2009-07-28 at 22:35 +0200, Hannes Eder wrote:
>> Since pr_err and friends is used instead of printk there is not point
>> in keeping IP_VS_ERR and friends.
>> +			pr_err("Schedule: port zero only supported "
>> +			       "in persistent services, "
>> +			       "check your ipvs configuration\n");
> 
> You might consider ignoring the checkpatch 80 char limit here
> and consolidate the message into a single string.

I don't think this is such a big deal.

>> -		IP_VS_ERR("ip_vs_svc_unhash(): request for unhash flagged, "
>> -			  "called from %p\n", __builtin_return_address(0));
>> +		pr_err("ip_vs_svc_unhash(): request for unhash flagged, "
>> +		       "called from %p\n", __builtin_return_address(0));
> 
> Maybe use something like:
> 	"%s(): <foo> called from %pf",
> 	 __func__, __builtin_return_address(0)
> 

However I do agree that this change should be made.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/