linux-kernel - Re: [PATCH] kmemleak: Protect the seq start/next/stop sequence by rcu_read

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <1248942284.3376.2.camel@pc1117.cambridge.arm.com>
Date:	Thu, 30 Jul 2009 09:24:44 +0100
From:	Catalin Marinas <catalin.marinas@....com>
To:	Andrew Morton <akpm@...ux-foundation.org>
Cc:	torvalds@...ux-foundation.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] kmemleak: Protect the seq start/next/stop sequence by
	rcu_read_lock()

On Wed, 2009-07-29 at 17:00 -0700, Andrew Morton wrote:
> On Wed, 29 Jul 2009 16:26:57 +0100
> Catalin Marinas <catalin.marinas@....com> wrote:
> 
> > Objects passed to kmemleak_seq_next() have an incremented reference
> > count (hence not freed) but they may point via object_list.next to
> > other freed objects. To avoid this, the whole start/next/stop sequence
> > must be protected by rcu_read_lock().
> > 
> > Signed-off-by: Catalin Marinas <catalin.marinas@....com>
> > ---
> > 
> > This is a fix for bug #13761 in buzilla.kernel.org. If there are no
> > objections, please apply it before 2.6.31. Thanks.
> 
> Administrivia:
> 
> When referencing a bugzilla report, please quote the full URL within
> the changelog (not after the ^---$).  I use:
> 
> 	Addresses http://bugzilla.kernel.org/show_bug.cgi?id=13761
> 
> This is because people ocassionally troll the commit logs, closing off
> bugzilla reports.  Using a standardised format simplifies that job, and
> makes it more reliable.
> 
> Also, it's nice to give the original bug reporter a Reported-by: in the
> changelog.  As a little thank-you, and so they know what's going on.

Yes, I agree. Thanks for adjusting these in the -mm tree patch.

-- 
Catalin

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/