linux-kernel - Re: [RFC] [PATCH 3/3 v2] ASoC: add support for Amstrad E3 (Delta) machine

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <4A72DC71.6020904@tis.icnet.pl>
Date:	Fri, 31 Jul 2009 13:58:41 +0200
From:	Janusz Krzysztofik <jkrzyszt@....icnet.pl>
To:	Mark Brown <broonie@...nsource.wolfsonmicro.com>
CC:	Alan Cox <alan@...rguk.ukuu.org.uk>,
	Jarkko Nikula <jhnikula@...il.com>,
	Jonathan McDowell <noodles@...th.li>,
	Peter Ujfalusi <peter.ujfalusi@...ia.com>,
	Tony Lindgren <tony@...mide.com>, alsa-devel@...a-project.org,
	"linux-serial@...r.kernel.org" <linux-serial@...r.kernel.org>,
	"linux-omap@...r.kernel.org" <linux-omap@...r.kernel.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	e3-hacking@...th.li, Arun KS <arunks@...tralsolutions.com>
Subject: Re: [RFC] [PATCH 3/3 v2] ASoC: add support for Amstrad E3 (Delta)
 machine

Mark Brown wrote:
> On Wed, Jul 29, 2009 at 01:18:53PM +0200, Janusz Krzysztofik wrote:
> 
>> 2) patch 2/3 form this series: TTY: Add definition of a new line
>>    discipline required by Amstrad E3 (Delta) ASoC driver[2].
> 
> The ASoC parts of this all look OK - what's the status of the TTY patch?
> 

Alan replied off-list yet before v2 submission. Then I replied him 
off-list as well... I hope he doesn't mind quoting him here.

Janusz Krzysztofik wrote:
> Alan Cox wrote:
>> Interesting use of a line discipline. The tty/ldisc bits look good to me
>>
> 
> Thanks.
> Could you please have a look at today's version 2 of the patch 3/3 as 
> well? The ldisc bits has been split into machine and codec related parts 
> and, what's more important, updated with locking that I am not quite 
> sure about its correctness.
> 
> Furthermore, I am still thinking about renaming the ldisc with a more 
> generic name. That way, it could be probably reused by other similiar 
> implementations. As long as the ldisc is registered from a board 
> specific code, it should not interfere with other implemnetations 
> reusing the same ldisc number, even if compiled in side by side.

Any objections on renaming ldisc from N_AMSDLETA to N_V253?

Thnaks,
Janusz

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/