linux-kernel - Re: [PATCH update] PM: Introduce core framework for run-time PM of I/O devices (rev. 11)

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <aec7e5c30907310732u35faa15fpab070025f596463e@mail.gmail.com>
Date:	Fri, 31 Jul 2009 23:32:13 +0900
From:	Magnus Damm <magnus.damm@...il.com>
To:	"Rafael J. Wysocki" <rjw@...k.pl>
Cc:	Alan Stern <stern@...land.harvard.edu>, Greg KH <gregkh@...e.de>,
	LKML <linux-kernel@...r.kernel.org>,
	ACPI Devel Maling List <linux-acpi@...r.kernel.org>,
	Linux-pm mailing list <linux-pm@...ts.linux-foundation.org>,
	Pavel Machek <pavel@....cz>
Subject: Re: [PATCH update] PM: Introduce core framework for run-time PM of 
	I/O devices (rev. 11)

Hi Rafail

[Runtime PM v11]

Thanks for your work on this. The code is getting better and better.
I've just finished posting a bunch of patches related to v11 of your
Runtime PM patch. Basically everything seems fine except a few minor
details and the code below: =)

On Thu, Jul 23, 2009 at 4:10 AM, Rafael J. Wysocki<rjw@...k.pl> wrote:
> On Wednesday 22 July 2009, Rafael J. Wysocki wrote:
> Index: linux-2.6/drivers/base/dd.c
> ===================================================================
> --- linux-2.6.orig/drivers/base/dd.c
> +++ linux-2.6/drivers/base/dd.c
> @@ -23,6 +23,7 @@
>  #include <linux/kthread.h>
>  #include <linux/wait.h>
>  #include <linux/async.h>
> +#include <linux/pm_runtime.h>
>
>  #include "base.h"
>  #include "power/power.h"
> @@ -202,7 +203,9 @@ int driver_probe_device(struct device_dr
>        pr_debug("bus: '%s': %s: matched device %s with driver %s\n",
>                 drv->bus->name, __func__, dev_name(dev), drv->name);
>
> +       pm_runtime_get_noresume(dev);
>        ret = really_probe(dev, drv);
> +       pm_runtime_put_noidle(dev);
>
>        return ret;
>  }

This creates problems when drivers want to performing runtime resume
from within probe(). For more details please have a look at "[PATCH
04/04] video: Runtime PM hack for SuperH LCDC driver".

Cheers,

/ magnus
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/