linux-kernel - Re: [PATCH 1/4] [atm] fixed faulty check

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <4A723958.3030807@traverse.com.au>
Date:	Fri, 31 Jul 2009 10:22:48 +1000
From:	Nathan Williams <nathan@...verse.com.au>
To:	Stoyan Gaydarov <sgayda2@...c.edu>
CC:	linux-kernel@...r.kernel.org, chas@....nrl.navy.mil,
	David.Woodhouse@...el.com, netdev@...r.kernel.org
Subject: Re: [PATCH 1/4] [atm] fixed faulty check

Stoyan Gaydarov wrote:
> This patche fixes a spelling error that has resulted from copy and pasting. The location of the error was found using a semantic patch but the semantic patch was not trying to find these errors. After looking things over it seemed logical that this change was needed. Please review it and then include the patch if it is in fact the correct change.
> 
> Signed-off-by: Stoyan Gaydarov <sgayda2@...c.edu>
> ---
>  drivers/atm/solos-pci.c |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
> 
> diff --git a/drivers/atm/solos-pci.c b/drivers/atm/solos-pci.c
> index 9359613..307321b 100644
> --- a/drivers/atm/solos-pci.c
> +++ b/drivers/atm/solos-pci.c
> @@ -372,7 +372,7 @@ static int process_status(struct solos_card *card, int port, struct sk_buff *skb
>  	}
>  
>  	snr = next_string(skb);
> -	if (!str)
> +	if (!snr)
>  		return -EIO;
>  	attn = next_string(skb);
>  	if (!attn)

Thanks Stoyan.  Julia Lawall found this error a few days ago, which has been applied to net-next-2.6.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/