[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20090731172002.GA32578@rakim.wolfsonmicro.main>
Date: Fri, 31 Jul 2009 18:20:02 +0100
From: Mark Brown <broonie@...nsource.wolfsonmicro.com>
To: Roger Quadros <quadros.roger@...il.com>
Cc: philipp.zabel@...il.com, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2] regulator: Add GPIO enable control to fixed voltage
regulator driver
On Fri, Jul 31, 2009 at 07:19:49PM +0300, Roger Quadros wrote:
> Signed-off-by: Roger Quadros <ext-roger.quadros@...ia.com>
> Reviewed-by: Mark Brown <broonie@...nsource.wolfsonmicro.com>
Err... no, it isn't. I reviewed a previous version of the patch but
there were some issues that needed fixing. I've not reviewed this
version.
> static int fixed_voltage_is_enabled(struct regulator_dev *dev)
> {
> - return 1;
> + struct fixed_voltage_data *data = rdev_get_drvdata(dev);
> +
> + if (data->gpio)
> + return data->is_enabled;
Please use gpio_is_valid() as Phillip previously suggested. For this
particular use you could simplify the code marginally by just setting
is_enabled at probe() time if there's no GPIO, not that it really
matters.
> + if (data->gpio) {
> + gpio_set_value(data->gpio,
> + data->enable_high ? 1 : 0);
_cansleep(), please, as previously requested.
> + ret = gpio_get_value(config->gpio);
Can this fail? It returns an int...
> + ret = gpio_direction_output(config->gpio, ret);
> + if (ret) {
> + dev_err(&pdev->dev, "Could not configure "
> + "enable GPIO %d direction: %d\n",
> + config->gpio, ret);
> + goto err_gpio;
As previously requested please don't split for log messages text over
lines unless you have to. It makes it easier to find the message from a
kernel log - grep for 'configure enable GPIO' won't match this source
file the way you've written it above.
> + }
> + } else
> + dev_warn(&pdev->dev, "Not using GPIO 0 for enable control\n");
Probably better to soldier on and use the GPIO here but either way is
fine; the warning is for the benefit of existing out of tree users to
help them transition gracefully.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists