linux-kernel - Re: [PATCH -tip] x86: oprofile/op_model_amd.c set return values for op_amd_handle

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Fri, 31 Jul 2009 13:29:27 -0700
From:	Andrew Morton <akpm@...ux-foundation.org>
To:	Robert Richter <robert.richter@....com>
Cc:	jaswinder@...nel.org, mingo@...e.hu, x86@...nel.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH -tip] x86: oprofile/op_model_amd.c set return values for
 op_amd_handle_ibs()

On Thu, 18 Jun 2009 16:47:31 +0200
Robert Richter <robert.richter@....com> wrote:

> On 18.06.09 17:09:27, Jaswinder Singh Rajput wrote:
> > 
> > op_amd_handle_ibs() should return 0 when IBS is not present or not defined.
> > 
> > Fix compilation warning:
> >  CC [M]  arch/x86/oprofile/op_model_amd.o
> >  arch/x86/oprofile/op_model_amd.c: In function ___op_amd_handle_ibs___:
> >  arch/x86/oprofile/op_model_amd.c:217: warning: no return statement in function returning non-void
> > 
> > Signed-off-by: Jaswinder Singh Rajput <jaswinderrajput@...il.com>
> > ---
> >  arch/x86/oprofile/op_model_amd.c |    7 +++++--
> >  1 files changed, 5 insertions(+), 2 deletions(-)
> 
> Applied to:
> 
>  git://git.kernel.org/pub/scm/linux/kernel/git/rric/oprofile.git master
> 

Something has gone badly wrong.  This patch took six weeks to turn up
in linux-next.

Apart from anything else this led me to have to fix something which was
already fixed.

All you guys *saw* that fix and still this didn't prompt anyone to
wonder what had gone wrong.

My fix is better, too.  The op_amd_handle_ibs() return value is
ignored, so it should return void.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/