linux-kernel - Re: [linux-cifs-client] [PATCH] cifs: reinstate original behavior when uid=/gid= options are specified

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20090731171104.33dbc30c@tlielax.poochiereds.net>
Date:	Fri, 31 Jul 2009 17:11:04 -0400
From:	Jeff Layton <jlayton@...hat.com>
To:	Shirish Pargaonkar <shirishpargaonkar@...il.com>
Cc:	linux-cifs-client@...ts.samba.org, linux-kernel@...r.kernel.org,
	linux-fsdevel@...r.kernel.org
Subject: Re: [linux-cifs-client] [PATCH] cifs: reinstate original behavior 
 when uid=/gid= options are specified

On Fri, 31 Jul 2009 14:26:15 -0500
Shirish Pargaonkar <shirishpargaonkar@...il.com> wrote:

> Should override_uid  and override_gid be initialized to 1 so that if
> uid and/or gid
> are specified and none of the options, either forceuid/gid and or
> noforceuid/gid are
> specified, the vol-> override defaults to 1 (i.e. forceuid/gid)?
> 

No, I'm using -1 as an indicator of "uninitialized". It's still
considered "true" when cast to a bool (which is what vol->override_*
actually are). That's how I can tell if someone specified forceuid with
no uid= option.
-- 
Jeff Layton <jlayton@...hat.com>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/