linux-kernel - Re: [PATCH v2] regulator: Add GPIO enable control to fixed voltage regulator driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20090731214401.GC6335@sirena.org.uk>
Date:	Fri, 31 Jul 2009 22:44:01 +0100
From:	Mark Brown <broonie@...nsource.wolfsonmicro.com>
To:	Roger Quadros <quadros.roger@...il.com>
Cc:	pHilipp Zabel <philipp.zabel@...il.com>,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2] regulator: Add GPIO enable control to fixed voltage
 regulator driver

On Fri, Jul 31, 2009 at 11:32:32PM +0300, Roger Quadros wrote:

> Not having gpio_get_direction() in gpiolib is a limitation I think.
> Can we just do the following for now ? (i.e. disable regulator by default)
> Will there be any glitch? If yes, then how?

If you're going to do this then like I say you should make the default
state controllable by platform data.  If we unconditionally disable the
regulator then if, for example, the regulator is controlling the display
backlight and it's on when Linux get controls then the user will see the
backlight blink off then on during startup.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/