[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-Id: <200907310357.n6V3vFSr005759@mercury.physics.adelaide.edu.au>
Date: Fri, 31 Jul 2009 13:27:15 +0930 (CST)
From: Jonathan Woithe <jwoithe@...sics.adelaide.edu.au>
To: bzolnier@...il.com (Bartlomiej Zolnierkiewicz)
Cc: jwoithe@...sics.adelaide.edu.au (Jonathan Woithe),
linux-acpi@...r.kernel.org, linux-kernel@...r.kernel.org,
error27@...il.com (Dan Carpenter), corbet@....net,
eteo@...hat.com, julia@...u.dk (Julia Lawall)
Subject: Re: [PATCH] fujitsu-laptop: remove superfluous NULL pointer checks
Hi
> > > From: Bartlomiej Zolnierkiewicz <bzolnier@...il.com>
> > > Subject: [PATCH] fujitsu-laptop: remove superfluous NULL pointer checks
> > >
> > > This takes care of the following entries from Dan's list:
> > >
> > > drivers/platform/x86/fujitsu-laptop.c +327 set_lcd_level(13) warning: variable derefenced before check 'fujitsu'
> > > drivers/platform/x86/fujitsu-laptop.c +358 set_lcd_level_alt(13) warning: variable derefenced before check 'fujitsu'
> >
> > I'd rather keep the test for a non-null fujitsu in there, but obviously it's
> > kind of pointless doing it after the first dereference. Since this fixup
> > overlaps with the one previously discussed with Julia I've taken the liberty
>
> They are on top of Julia's patch (sorry I forgot to mention it)..
Ah, right. I was trying to work out where it fitted (that was probably the
one preceeding patch I *didn't* end up trying).
Regards
jonathan
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists