linux-kernel - Re: [PATCH] Moorestown RAR Handler driver, MRST 2.6.31-rc3

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Sat, 01 Aug 2009 01:03:02 -0700
From:	Joe Perches <joe@...ches.com>
To:	Sam Ravnborg <sam@...nborg.org>
Cc:	Ossama Othman <ossama.othman@...el.com>,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] Moorestown RAR Handler driver, MRST 2.6.31-rc3

On Sat, 2009-08-01 at 09:30 +0200, Sam Ravnborg wrote:
> > +#include "memrar_allocator.h"
> > +#include <linux/slab.h>
> > +#include <linux/bug.h>
> 
> <linux/...> comes _before_ you own includes.

The use of pr_fmt might change this guideline.

> > +		WARN(capacity < block_size * 2,
> > +		     "Memory allocator is only large enough to "
> > +		     "hold one block.\n");
> 
> Try to avoid breaking your printable line.
> It is much easier to grep for the line when it is on a single
> line.
> If you violate the 80 chars per line rule do to this then accept
> that grepable lines is better than keeping them 80 or less wide.

Maybe it's better to ignore the indent guideline here as well.
An outdent might be preferable to having the line exceed 80 chars.

Maybe:
		WARN(capacity < block_size * 2,
	"Memory allocator is only large enough to hold one block.\n");
or
		WARN(capacity < block_size * 2, 
"Memory allocator is only large enough to hold one block.\n");

Any format string longer than 80 chars is likely a poor log entry.


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/