linux-kernel - Re: [PATCH] basic perf support for sparc

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20090802195043.GD24486@elte.hu>
Date:	Sun, 2 Aug 2009 21:50:43 +0200
From:	Ingo Molnar <mingo@...e.hu>
To:	Kyle McMartin <kyle@...artin.ca>
Cc:	Arnaldo Carvalho de Melo <acme@...hat.com>,
	Jens Axboe <jens.axboe@...cle.com>,
	Anton Blanchard <anton@...ba.org>, davem@...emloft.net,
	linux-kernel@...r.kernel.org, a.p.zijlstra@...llo.nl,
	fweisbec@...il.com, benh@...nel.crashing.org,
	penberg@...helsinki.fi, vegard.nossum@...il.com, paulus@...ba.org,
	williams@...hat.com
Subject: Re: [PATCH] basic perf support for sparc


* Kyle McMartin <kyle@...artin.ca> wrote:

> On Sun, Aug 02, 2009 at 08:41:48PM +0200, Ingo Molnar wrote:
> > Could we somehow define a weak symbol for those library functions 
> > ourselves and thus just fall back to that (which does nothing) 
> > instead of failing the link?
> > 
> 
> Well, you could just dlopen the object, but that's kind of 
> gross...

hm, why is it gross? I think it's a nicely plug-and-play tooling 
solution - instead of some obscure make flag.

Since we define the prototype anyway:

> +static inline char *bfd_demangle(void __used *v, const char __used *c,
> +				int __used i) {
> +	return NULL;
> +}

We are sticking to a given version of the API. We could turn that 
into a function pointer and fill it in during startup via dlopen(). 
If it's NULL then we dont call it and assume a value of NULL.

Mind submitting such a version of your fix? It would nicely decrease 
the build requirements cross section surface of perf.

	Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/