[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <20090802195945.GD25334@ghostprotocols.net>
Date: Sun, 2 Aug 2009 16:59:45 -0300
From: Arnaldo Carvalho de Melo <acme@...hat.com>
To: Ingo Molnar <mingo@...e.hu>
Cc: Ray Lee <ray-lk@...rabbit.org>,
Frederic Weisbecker <fweisbec@...il.com>,
Mike Galbraith <efault@....de>,
Peter Zijlstra <a.p.zijlstra@...llo.nl>,
Paul Mackerras <paulus@...ba.org>,
"H. Peter Anvin" <hpa@...or.com>,
Linux Kernel Mailing List <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH 1/1 tip] perf top: Move hard coded list to
/etc/perfconfig/symbols.skip
Em Sun, Aug 02, 2009 at 09:55:33PM +0200, Ingo Molnar escreveu:
>
> * Ray Lee <ray-lk@...rabbit.org> wrote:
>
> > On Mon, Jul 27, 2009 at 5:10 PM, Arnaldo Carvalho de
> > Melo<acme@...hat.com> wrote:
> > > This also paves the way to add more symbol lists to be filtered out,
> > > spinlock anyone?
> >
> > Generally, the way I've found is best to handle things like this is to either:
> >
> > A. Have a fall-back list to use if the file isn't found, or
> > B. Start with the fall-back list of symbols to filter, then add to
> > them via /etc/... and ~/.perf/...
> >
> > I like approaching things from the 'everything works even in a
> > broken/hasty installation' point of view, and it's paid off for me.
> > Sane defaults are a wonderfully useful thing.
>
> Agreed.
>
> Also, i'd not pollute /etc just yet, please lets define a good
> default built-in list like we have now, and perhaps enable the
> extension of it via .perf/config.
>
> Tools should work well by default.
OK, I'll rework the patch and resubmit it.
- Arnaldo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists