[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20090802204647.GC3986@elte.hu>
Date: Sun, 2 Aug 2009 22:46:47 +0200
From: Ingo Molnar <mingo@...e.hu>
To: Andrew Morton <akpm@...ux-foundation.org>
Cc: paulmck@...ux.vnet.ibm.com, mingo@...hat.com, hpa@...or.com,
linux-kernel@...r.kernel.org, a.p.zijlstra@...llo.nl,
torvalds@...ux-foundation.org, tglx@...utronix.de,
linux-tip-commits@...r.kernel.org
Subject: Re: [tip:core/debug] debug lockups: Improve lockup detection
* Andrew Morton <akpm@...ux-foundation.org> wrote:
> #ifndef trigger_all_cpu_backtrace
> +#ifdef CONFIG_SMP
> +#warning This architecture is missing a trigger_all_cpu_backtrace() implementation
> +#endif
> #define trigger_all_cpu_backtrace() do { } while (0)
> #endif
I think a better solution will be to make this function return 1 if
it generated a backtrace.
That way we can fall back to the generic schedule_work based
codepath.
Albeit the best and cleanest solution would be to implement a
workqueue based trigger_all_cpu_backtrace() __weak variant and throw
away the workqueue bits from sysrq.c.
Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists