linux-kernel - Re: [RFC][patch 02/12] remove clocksource inline functions

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20090803101037.6989b427@skybase>
Date:	Mon, 3 Aug 2009 10:10:37 +0200
From:	Martin Schwidefsky <schwidefsky@...ibm.com>
To:	Valdis.Kletnieks@...edu
Cc:	Christoph Hellwig <hch@...radead.org>,
	Will Newton <will.newton@...il.com>, dwalker@...o99.com,
	linux-kernel@...r.kernel.org, Ingo Molnar <mingo@...e.hu>,
	Thomas Gleixner <tglx@...utronix.de>,
	john stultz <johnstul@...ibm.com>
Subject: Re: [RFC][patch 02/12] remove clocksource inline functions

On Fri, 31 Jul 2009 07:50:22 -0400
Valdis.Kletnieks@...edu wrote:

> On Thu, 30 Jul 2009 17:48:36 EDT, Christoph Hellwig said:
> > > You know that a priori because you're familiar with that code. But there's
> > > another use case: An idiot monkey like myself manages to break the kernel
> > > *again* in some part of the kernel they're totally unfamiliar with, and
> > > they need to discover for themselves that timekeeping.c is the only user.
> > > 
> > > (Of course, in another 5-6 years I'll probably have broken something in
> > > every part of the kernel and whinged at Andrew about it, and that argument
> > > won't apply anymore.. ;)
> > 
> > Andthe poor grepping monkey can be sure that everyone used the useless
> > wrapper exactly how?  If you want to help people with grepping rename
> > the method from read to clocksource_read..
> 
> Even better. ;)
 
With the same reasoning you could argue that f_ops->read should be
renamed to f_ops->file_read. And why is it so important to be able
to grep for clocksource_read? Not that a patch to rename read to
clocksource_read is hard but before I go ahead an do the rename for 60+
clocksources in the kernel I would like to have a better reason than
"I might want to grep it".

-- 
blue skies,
   Martin.

"Reality continues to ruin my life." - Calvin.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/