linux-kernel - Re: [PATCH] Switch atmel_serial to dev_pm

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20090803170947.2f199b93@hskinnemoen-d830>
Date:	Mon, 3 Aug 2009 17:09:47 +0200
From:	Haavard Skinnemoen <haavard.skinnemoen@...el.com>
To:	Albin Tonnerre <albin.tonnerre@...e-electrons.com>
Cc:	nicolas.ferre@...el.com, linux@...im.org.za,
	linux-kernel@...r.kernel.org,
	Albin Tonnerre <albin.tonnerre@...e-electrons.com>
Subject: Re: [PATCH] Switch atmel_serial to dev_pm_ops

Albin Tonnerre wrote:
> +static struct dev_pm_ops atmel_serial_pm_ops = {
> +	.suspend = atmel_serial_suspend,
> +	.resume = atmel_serial_resume,
> +};
>  #else
> -#define atmel_serial_suspend NULL
> -#define atmel_serial_resume NULL
> +static struct dev_pm_ops atmel_serial_pm_ops;

Why not

#define atmel_serial_pm_ops	NULL

>  #endif
>  
>  static int __devinit atmel_serial_probe(struct platform_device *pdev)
> @@ -1603,11 +1607,10 @@ static int __devexit atmel_serial_remove(struct platform_device *pdev)
>  static struct platform_driver atmel_serial_driver = {
>  	.probe		= atmel_serial_probe,
>  	.remove		= __devexit_p(atmel_serial_remove),
> -	.suspend	= atmel_serial_suspend,
> -	.resume		= atmel_serial_resume,
>  	.driver		= {
>  		.name	= "atmel_usart",
>  		.owner	= THIS_MODULE,
> +		.pm = &atmel_serial_pm_ops,

Please use a TAB instead of space to make everything nice and
consistent.

Other than that,

Acked-by: Haavard Skinnemoen <haavard.skinnemoen@...el.com>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/