linux-kernel - Re: [PATCH 20/25] io-controller: map async requests to appropriate cgroup

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <4A7647DA.5050607@cn.fujitsu.com>
Date:	Mon, 03 Aug 2009 10:13:46 +0800
From:	Gui Jianfeng <guijianfeng@...fujitsu.com>
To:	Vivek Goyal <vgoyal@...hat.com>
CC:	linux-kernel@...r.kernel.org,
	containers@...ts.linux-foundation.org, dm-devel@...hat.com,
	jens.axboe@...cle.com, nauman@...gle.com, dpshah@...gle.com,
	lizf@...fujitsu.com, mikew@...gle.com, fchecconi@...il.com,
	paolo.valente@...more.it, ryov@...inux.co.jp,
	fernando@....ntt.co.jp, s-uchida@...jp.nec.com, taka@...inux.co.jp,
	jmoyer@...hat.com, dhaval@...ux.vnet.ibm.com,
	balbir@...ux.vnet.ibm.com, righi.andrea@...il.com,
	m-ikeda@...jp.nec.com, jbaron@...hat.com, agk@...hat.com,
	snitzer@...hat.com, akpm@...ux-foundation.org, peterz@...radead.org
Subject: Re: [PATCH 20/25] io-controller: map async requests to appropriate
 cgroup

Vivek Goyal wrote:
...
> +
> +struct io_group *io_get_io_group_bio(struct request_queue *q, struct bio *bio,
> +					int create)
> +{
> +	struct page *page = NULL;
> +
> +	/*
> +	 * Determine the group from task context. Even calls from
> +	 * blk_get_request() which don't have any bio info will be mapped
> +	 * to the task's group
> +	 */
> +	if (!bio)
> +		goto sync;
> +
> +	if (bio_barrier(bio)) {
> +		/*
> +		 * Map barrier requests to root group. May be more special
> +		 * bio cases should come here
> +		 */
> +		return q->elevator->efqd.root_group;
> +	}
> +
> +	/* Map the sync bio to the right group using task context */
> +	if (elv_bio_sync(bio))
> +		goto sync;
> +
> +#ifdef CONFIG_TRACK_ASYNC_CONTEXT
> +	/* Determine the group from info stored in page */
> +	page = bio_iovec_idx(bio, 0)->bv_page;
> +	return io_get_io_group(q, page, create);
> +#endif
> +
> +sync:
> +	return io_get_io_group(q, NULL, create);

Fix build warning.

block/elevator-fq.c: In function ‘io_get_io_group_bio’:
block/elevator-fq.c:2075: warning: unused variable ‘page’

---
diff --git a/block/elevator-fq.c b/block/elevator-fq.c
index 66b10eb..d304f79 100644
--- a/block/elevator-fq.c
+++ b/block/elevator-fq.c
@@ -2102,7 +2102,7 @@ struct io_group *io_get_io_group_bio(struct request_queue *q, struct bio *bio,
 #endif
 
 sync:
-	return io_get_io_group(q, NULL, create);
+	return io_get_io_group(q, page, create);
 }
 EXPORT_SYMBOL(io_get_io_group_bio);


> +}
> +EXPORT_SYMBOL(io_get_io_group_bio);
> +


-- 
Regards
Gui Jianfeng

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/