[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20090803180137.6961a832@hskinnemoen-d830>
Date: Mon, 3 Aug 2009 18:01:37 +0200
From: Haavard Skinnemoen <haavard.skinnemoen@...el.com>
To: Albin Tonnerre <albin.tonnerre@...e-electrons.com>
Cc: nicolas.ferre@...el.com, linux@...im.org.za,
linux-kernel@...r.kernel.org
Subject: Re: [PATCH] Switch atmel_serial to dev_pm_ops
Albin Tonnerre wrote:
> On Mon, Aug 03, 2009 at 05:09:47PM +0200, Haavard Skinnemoen wrote :
> > Why not
>
> > #define atmel_serial_pm_ops NULL
>
> Because the .pm field is set to the address of atmel_serial_pm_ops, and iirc
> taking the address of NULL is not allowed.
Good point.
> > > .name = "atmel_usart",
> > > .owner = THIS_MODULE,
> > > + .pm = &atmel_serial_pm_ops,
>
> > Please use a TAB instead of space to make everything nice and
> > consistent.
>
> That's weird, because my editor does show a TAB there, and applying the patch
> with git am results in a TAB.
Hmm, it doesn't show a TAB when I apply it here...
Oh well, it's not a big deal either way.
Haavard
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists