linux-kernel - Re: [PATCH] fs/compat_ioctl.c: add missing FS_IOC

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <4A7725AF.6090106@redhat.com>
Date:	Mon, 03 Aug 2009 13:00:15 -0500
From:	Eric Sandeen <sandeen@...hat.com>
To:	Mark Lord <lkml@....ca>
CC:	Linux Kernel <linux-kernel@...r.kernel.org>,
	linux-ext4@...r.kernel.org, Eric Sandeen <sandeen@...deen.net>,
	Andrew Morton <akpm@...ux-foundation.org>
Subject: Re: [PATCH] fs/compat_ioctl.c: add missing FS_IOC_FIEMAP support

Mark Lord wrote:
> (resending, no ack from anyone first time around).

I had previously sent a fix for this to the ext4 list as well, although
w/o the added case for compat_ioctl or the extra #include.

Because this ioctl should be 100% compat everywhere, I don't -think-
it's needed, and

http://marc.info/?l=linux-ext4&m=124872536713005&w=2

suffices....

But if not, minor nitpick, you should move the COMPAT_IOCTL under the
"little f" comment.

-Eric


> Add support for the FIEMAP ioctl for 32-bit user on 64-bit kernel.
> 
> When using a 32-bit runtime on top of a 64-bit kernel,
> programs like "filefrag" and "hdparm --fibmap" do not work correctly.
> 
> This is because there's no compat ioctl entry for the FIEMAP call.
> FIEMAP returns file extent info, similar to FIBMAP (but better).
> 
> Since FIBMAP itself is b0rked on ext4, this leaves no way for a 32-bit
> program to reliably get detailed block information for a file
> when run on top of a 64-bit kernel.  This patch addresses the issue.
> 
> Once upstream, this patch could also be a candidate for -stable.
> 
> Signed-off-by: Mark Lord <mlord@...ox.com>
> 
> Add support for the FIEMAP ioctl for 32-bit user on 64-bit kernel.
> 
> When using a 32-bit runtime on top of a 64-bit kernel,
> programs like "filefrag" and "hdparm --fibmap" do not work correctly.
> 
> This is because there's no compat ioctl entry for the FIEMAP call.
> FIEMAP returns file extent info, similar to FIBMAP (but better).
> 
> Since FIBMAP itself is b0rked on ext4, this leaves no way for a 32-bit
> program to reliably get detailed block information for a file
> when run on top of a 64-bit kernel.  This patch addresses the issue.
> 
> Once upstream, this patch could also be a candidate for -stable.
> 
> Signed-off-by: Mark Lord <mlord@...ox.com> 
> 
> --- old/fs/compat_ioctl.c	2009-08-01 10:47:16.601066905 -0400
> +++ linux/fs/compat_ioctl.c	2009-08-01 10:49:23.054387926 -0400
> @@ -35,6 +35,7 @@
>  #include <linux/falloc.h>
>  #include <linux/fs.h>
>  #include <linux/file.h>
> +#include <linux/fiemap.h>
>  #include <linux/ppp_defs.h>
>  #include <linux/if_ppp.h>
>  #include <linux/if_pppox.h>
> @@ -1907,6 +1908,7 @@
>  COMPATIBLE_IOCTL(FIONREAD)  /* This is also TIOCINQ */
>  /* 0x00 */
>  COMPATIBLE_IOCTL(FIBMAP)
> +COMPATIBLE_IOCTL(FS_IOC_FIEMAP)
>  COMPATIBLE_IOCTL(FIGETBSZ)
>  /* 'X' - originally XFS but some now in the VFS */
>  COMPATIBLE_IOCTL(FIFREEZE)
> @@ -2805,6 +2807,7 @@
>  		goto out_fput;
>  #endif
>  
> +	case FS_IOC_FIEMAP:
>  	case FIBMAP:
>  	case FIGETBSZ:
>  	case FIONREAD:
> --
> To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
> the body of a message to majordomo@...r.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/