[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <4A77443D.9020105@novell.com>
Date: Mon, 03 Aug 2009 16:10:37 -0400
From: Gregory Haskins <ghaskins@...ell.com>
To: Stephen Hemminger <shemminger@...tta.com>
CC: linux-kernel@...r.kernel.org,
alacrityvm-devel@...ts.sourceforge.net, netdev@...r.kernel.org
Subject: Re: [PATCH 6/7] net: Add vbus_enet driver
Stephen Hemminger wrote:
> On Mon, 03 Aug 2009 13:18:02 -0400
> Gregory Haskins <ghaskins@...ell.com> wrote:
>
>> +
>> +static const struct net_device_ops vbus_enet_netdev_ops = {
>> + .ndo_open = vbus_enet_open,
>> + .ndo_stop = vbus_enet_stop,
>> + .ndo_set_config = vbus_enet_config,
>> + .ndo_start_xmit = vbus_enet_tx_start,
>> + .ndo_change_mtu = vbus_enet_change_mtu,
>> + .ndo_tx_timeout = vbus_enet_timeout,
>> +};
>
>
> Missing
> .ndo_set_mac_address = eth_mac_addr,
> .ndo_validate_addr = eth_validate_addr,
>
Ack.
> Also, should have change_mtu.
note that I do have .ndo_change_mtu. I assume this is what you are
referring to and just missed it. If there is something else I need
there, let me know.
Kind Regards,
-Greg
Download attachment "signature.asc" of type "application/pgp-signature" (268 bytes)
Powered by blists - more mailing lists