linux-kernel - Re: atl1c: Do not call cancel_work

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20090803.132049.77191266.davem@davemloft.net>
Date:	Mon, 03 Aug 2009 13:20:49 -0700 (PDT)
From:	David Miller <davem@...emloft.net>
To:	jie.yang@...eros.com
Cc:	netdev@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: atl1c: Do not call cancel_work_sync from the work itself

From: <jie.yang@...eros.com>
Date: Mon, 3 Aug 2009 13:32:19 +0800

> Signed-off-by: jie yang <jie.yang>@atheros.com

Your entire email address should be surrounded by '<' and '>'
characters, not just your username, in the signoff.

Also, please provide a more detailed commit message.  Explain what
goes wrong in the current code (when happens when a work is cancelled
within itself, I was under the impression that this works just fine
and is just a NOP), and the basic description of your solution.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/