linux-kernel - Re: [PATCH] md: avoid use of broken kzalloc mempool

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <Pine.LNX.4.64.0908031423140.7580@cobra.newdream.net>
Date:	Mon, 3 Aug 2009 14:29:26 -0700 (PDT)
From:	Sage Weil <sage@...dream.net>
To:	Andi Kleen <andi@...stfloor.org>
cc:	linux-kernel@...r.kernel.org, linux-raid@...r.kernel.org,
	Neil Brown <neilb@...e.de>, stable@...nel.org
Subject: Re: [PATCH] md: avoid use of broken kzalloc mempool

On Mon, 3 Aug 2009, Andi Kleen wrote:
> Sage Weil <sage@...dream.net> writes:
> 
> > The kzalloc mempool does not re-zero items that have been used and then
> > returned to the pool.  Manually zero the allocated multipath_bh instead.
> 
> Why not fix that in mempool instead? That would seem like the right place
> to fix such a bug, instead of adding workarounds to all callers.

That was my original proposal, but Andrew suggested it wasn't worth the 
added complexity for only 2 users (or actually, just 1).  See this thread:

http://marc.info/?l=linux-mm&m=124933189913260&w=2

sage
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/