linux-kernel - Re: [PATCH 1/1] XFS: __xfs_get_blocks check pointer to the target device

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20090803214929.GB3167@infradead.org>
Date:	Mon, 3 Aug 2009 17:49:30 -0400
From:	Christoph Hellwig <hch@...radead.org>
To:	Ramon de Carvalho Valle <ramon@...esecurity.org>
Cc:	linux-kernel@...r.kernel.org, mszeredi@...ell.com, hch@....de,
	xfs@....sgi.com
Subject: Re: [PATCH 1/1] XFS: __xfs_get_blocks check pointer to the target
	device

On Mon, Aug 03, 2009 at 05:03:28PM -0300, Ramon de Carvalho Valle wrote:
> The __xfs_get_blocks function does not check if the pointer to the target
> device is valid before dereferencing it.

It should never be zero.  It's set by xfs_imap_to_bmap to either
mp->m_ddev_targp which is always allocated, or to mp->m_rtdev_targp
which is always allocated if we have a realtime device, and
XFS_IS_REALTIME_INODE should only be true in that case.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/