linux-kernel - Re: [PATCH] x86, mce: cleanup initcall of debugfs for mce

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Tue, 04 Aug 2009 11:18:04 +0200
From:	Andi Kleen <ak@...ux.intel.com>
To:	Jin Dongming <jin.dongming@...css.fujitsu.com>
CC:	"H.Peter Anvin" <hpa@...or.com>,
	LKLM <linux-kernel@...r.kernel.org>, Ingo Molnar <mingo@...e.hu>,
	Huang Ying <ying.huang@...el.com>,
	Kenji Kaneshige <kaneshige.kenji@...fujitsu.com>,
	Hidetoshi Seto <seto.hidetoshi@...fujitsu.com>
Subject: Re: [PATCH] x86, mce: cleanup initcall of debugfs for mce


>  int mce_severity(struct mce *a, int tolerant, char **msg);
> -struct dentry *mce_get_debugfs_dir(void);
> +int __init severities_debugfs_init(struct dentry *dmce);

__init is not needed on prototypes.

Sorry but I think it's better to have an own initcall per file,
that makes everything more self contained and easier to read.

-Andi

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/