[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <20090804134609.GK18974@elf.ucw.cz>
Date: Tue, 4 Aug 2009 15:46:09 +0200
From: Pavel Machek <pavel@....cz>
To: Zhang Rui <rui.zhang@...el.com>
Cc: Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
linux-pm <linux-pm@...ts.linux-foundation.org>,
linux-acpi <linux-acpi@...r.kernel.org>,
"Rafael J. Wysocki" <rjw@...k.pl>, Len Brown <lenb@...nel.org>,
Alan Stern <stern@...land.harvard.edu>,
Arjan van de Ven <arjan@...ux.intel.com>,
"dtor@...l.ru" <dtor@...l.ru>
Subject: Re: [PATCH V2 4/4] i8042: support async suspend and shutdown
> > > panic_blink = i8042_panic_blink;
> > >
> > > return 0;
> > >
> > > + err_dev_async_unregister:
> > > + dev_async_unregister(&i8042_platform_device->dev);
> > > err_free_device:
> > > platform_device_put(i8042_platform_device);
> > > err_unregister_driver:
> >
> > I still do not like the interface: manually unregistering seems to be
> > ugly & error prone.
> >
> hmm, yes, we can check device->dev_async and unregister it in driver
> core, at device_unregister time.
>
> then I think we should rename the interfaces to:
> device_enable_async_action(dev, type),
> and device_disable_async_action(dev)
> so that they are more like driver core helper functions.
> what do you think?
Yes, that would be nicer.
Pavel
--
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists