linux-kernel - Re: [PATCH v2] add SBC-FITPC2 watchdog driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20090804153331.GA30892@infomag.iguana.be>
Date:	Tue, 4 Aug 2009 17:33:31 +0200
From:	Wim Van Sebroeck <wim@...ana.be>
To:	Mike Rapoport <mike@...pulab.co.il>,
	Denis Turischev <denis@...pulab.co.il>
Cc:	Joe Perches <joe@...ches.com>, LKML <linux-kernel@...r.kernel.org>,
	Andrey Panin <pazke@...trinvest.ru>, akpm@...ux-foundation.org
Subject: Re: [PATCH v2] add SBC-FITPC2 watchdog driver

Hi Mike, Denis,

> > From: Denis Turischev <denis@...pulab.co.il>
> 
> This patch adds support for watchdog found on SBC-FITPC2 board.
> 
> --
> v2 changes:
> - reorder fitpc2_wdt_write to reduce the indent
> - change printk levels
> - use pr_fmt
> - add release_region in the _init error path
> 
> Signed-off-by: Denis Turischev <denis@...pulab.co.il>
> Signed-off-by: Mike Rapoport <mike@...pulab.co.il>

Some remarks:
1) If you dou request_regions in the init section then you need to do release_regions also in the exit section.
2) we prefer:
 static long wdt_ioctl(parameters
			rest_of_parameters)
instead of
 static long
 wdt_ioctl(parameters)
3) misc_deregister can return with an error. If it does you need to do the release_regions also.
4) as Andrew allready pointed out spinlock needs to be initialized.
5) if you don't use the reboot_notifier then you don't need to include linux/notifier.h and linux/reboot.h .

I adapted the code.
Can you test the attached diff?

Thanks in advance,
Wim.


View attachment "sbc-fitpc2.diff" of type "text/x-diff" (7650 bytes)