linux-kernel - Re: [PATCH 3/6] KEYS: Flag dead keys to induce EKEYREVOKED

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20090804182254.GB8442@us.ibm.com>
Date:	Tue, 4 Aug 2009 13:22:54 -0500
From:	"Serge E. Hallyn" <serue@...ibm.com>
To:	David Howells <dhowells@...hat.com>
Cc:	torvalds@...l.org, akpm@...ux-foundation.org, jmorris@...ei.org,
	linux-kernel@...r.kernel.org, linux-security-module@...r.kernel.org
Subject: Re: [PATCH 3/6] KEYS: Flag dead keys to induce EKEYREVOKED

Quoting David Howells (dhowells@...hat.com):
> Set the KEY_FLAG_DEAD flag on keys for which the type has been removed.  This
> causes the key_permission() function to return EKEYREVOKED in response to
> various commands.  It does not, however, prevent unlinking or clearing of
> keyrings from detaching the key.
> 
> Signed-off-by: David Howells <dhowells@...hat.com>

Acked-by: Serge Hallyn <serue@...ibm.com>

> ---
> 
>  security/keys/key.c |    4 +++-
>  1 files changed, 3 insertions(+), 1 deletions(-)
> 
> 
> diff --git a/security/keys/key.c b/security/keys/key.c
> index 3762d5b..bd9d267 100644
> --- a/security/keys/key.c
> +++ b/security/keys/key.c
> @@ -956,8 +956,10 @@ void unregister_key_type(struct key_type *ktype)
>  	for (_n = rb_first(&key_serial_tree); _n; _n = rb_next(_n)) {
>  		key = rb_entry(_n, struct key, serial_node);
> 
> -		if (key->type == ktype)
> +		if (key->type == ktype) {
>  			key->type = &key_type_dead;
> +			set_bit(KEY_FLAG_DEAD, &key->flags);
> +		}
>  	}
> 
>  	spin_unlock(&key_serial_lock);
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/