[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <5007.1249417827@redhat.com>
Date: Tue, 04 Aug 2009 21:30:27 +0100
From: David Howells <dhowells@...hat.com>
To: "Serge E. Hallyn" <serue@...ibm.com>
Cc: dhowells@...hat.com, torvalds@...l.org, akpm@...ux-foundation.org,
jmorris@...ei.org, linux-kernel@...r.kernel.org,
linux-security-module@...r.kernel.org
Subject: Re: [PATCH 4/6] KEYS: Add garbage collection for dead, revoked and expired keys.
Serge E. Hallyn <serue@...ibm.com> wrote:
> These two lines (repeated below) beg for a helper?
Yeah... Seems reasonable.
> Can this happen? This implies that the number of live keys
> went up, but we're under keyring->sem?
An expired key can be updated back to life:
[root@...romeda ~]# keyctl add user a a @s
619170185
[root@...romeda ~]# keyctl timeout 619170185 5
[root@...romeda ~]# keyctl show
Session Keyring
-3 --alswrv 0 0 keyring: _ses
627083299 --alswrv 0 -1 \_ keyring: _uid.0
619170185 --alswrv 0 0 \_ user: a
[root@...romeda ~]# keyctl show
Session Keyring
-3 --alswrv 0 0 keyring: _ses
627083299 --alswrv 0 -1 \_ keyring: _uid.0
619170185: key inaccessible (Key has expired)
[root@...romeda ~]# keyctl add user a a @s
619170185
[root@...romeda ~]# keyctl show
Session Keyring
-3 --alswrv 0 0 keyring: _ses
627083299 --alswrv 0 -1 \_ keyring: _uid.0
619170185 --alswrv 0 0 \_ user: a
> > + .data = &key_gc_delay,
>
> I see where this variable is defined at top of the patch, but
> I don't see where it is actually used?
Bah! I forgot to add gc.c to the mix. Sorry about that.
David
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists