linux-kernel - Re: [PATCH 9/10] drivers/ata: introduce missing kfree

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <4A77BDCC.1070502@kernel.org>
Date:	Tue, 04 Aug 2009 13:49:16 +0900
From:	Tejun Heo <tj@...nel.org>
To:	Julia Lawall <julia@...u.dk>
CC:	jgarzik@...ox.com, linux-ide@...r.kernel.org,
	linux-kernel@...r.kernel.org, kernel-janitors@...r.kernel.org,
	geomatsi@...il.com
Subject: Re: [PATCH 9/10] drivers/ata: introduce missing kfree

Julia Lawall wrote:
...
> ---
>  drivers/ata/pata_at91.c             |    4 +++-
>  1 files changed, 3 insertions(+), 1 deletions(-)
> 
> diff --git a/drivers/ata/pata_at91.c b/drivers/ata/pata_at91.c
> index 5702aff..46fb883 100644
> --- a/drivers/ata/pata_at91.c
> +++ b/drivers/ata/pata_at91.c
> @@ -261,7 +261,8 @@ static int __devinit pata_at91_probe(struct platform_device *pdev)
>  
>  	if (IS_ERR(info->mck)) {
>  		dev_err(dev, "failed to get access to mck clock\n");
> -		return -ENODEV;
> +		ret = -ENODEV;
> +		goto err_clk_get;
>  	}
>  
>  	info->cs    = board->chipselect;
> @@ -308,6 +309,7 @@ err_alt_ioremap:
>  
>  err_ide_ioremap:
>  	clk_put(info->mck);
> +err_clk_get:
>  	kfree(info);

cc'ing Matyukevich Sergey.  Matyukevich, is it possible to use
devm_kzalloc() instead?

Thanks.

-- 
tejun
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/