linux-kernel - Re: [PATCH 4/6] KEYS: Add garbage collection for dead, revoked and expired keys. [ver #2]

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <alpine.LRH.2.00.0908051028100.29562@tundra.namei.org>
Date:	Wed, 5 Aug 2009 10:29:29 +1000 (EST)
From:	James Morris <jmorris@...ei.org>
To:	David Howells <dhowells@...hat.com>
cc:	torvalds@...l.org, akpm@...ux-foundation.org, serue@...ibm.com,
	linux-kernel@...r.kernel.org, linux-security-module@...r.kernel.org
Subject: Re: [PATCH 4/6] KEYS: Add garbage collection for dead, revoked and
 expired keys. [ver #2]

On Tue, 4 Aug 2009, David Howells wrote:

> +void key_schedule_gc(time_t gc_at)
> +{
> +	unsigned long expires;
> +	time_t now = current_kernel_time().tv_sec;
> +
> +	kenter("%ld", gc_at - now);
> +
> +	gc_at += key_gc_delay;
> +
> +	if (now >= gc_at) {

Should you be using time_after() and friends for these comparisons?


-- 
James Morris
<jmorris@...ei.org>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/