linux-kernel - Re: [PATCH 1/2] chrdev: implement __[un]register

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <s5hy6pyd8vx.wl%tiwai@suse.de>
Date:	Wed, 05 Aug 2009 09:20:34 +0200
From:	Takashi Iwai <tiwai@...e.de>
To:	Tejun Heo <tj@...nel.org>
Cc:	Greg KH <greg@...ah.com>, Al Viro <viro@....linux.org.uk>,
	Linux Kernel <linux-kernel@...r.kernel.org>,
	cguthrie@...driva.org
Subject: Re: [PATCH 1/2] chrdev: implement __[un]register_chrdev()

At Wed, 05 Aug 2009 16:11:21 +0900,
Tejun Heo wrote:
> 
> Takashi Iwai wrote:
> > At Wed, 05 Aug 2009 15:35:42 +0900,
> > Tejun Heo wrote:
> >> [un]register_chrdev() assume minor range 0-255.  This patch adds __
> >> prefixed versions which take @minorbase and @count explicitly.
> >>
> >> Signed-off-by: Tejun Heo <tj@...nel.org>
> >> Cc: Al Viro <viro@...iv.linux.org.uk>
> >> Cc: Greg Kroah-Hartman <gregkh@...e.de>
> >> ---
> >> Hello,
> >>
> >> These two patches make sound_core grabbing OSS device number optional.
> >> If there's no objection, I think it would be easiest to push this
> >> through Takashi's tree.
> > 
> > I'm fine to take this.
> > 
> > But, I think EXPORT_SYMBOL(__register_chrdev) and
> > EXPORT_SYMBOL(__unregister_chrdev) are missing in this patch.
> 
> The only current users would be sound_core.c which is always compiled
> built-in. 

CONFIG_SOUND is tristate, so it can be a module.
Actually SUSE kernels have it as a module :)

> Adrian would be mighty unhappy about adding EXPORT_SYMBOL()
> there.

How about to replace the old *register_chrdev() with static inline,
instead?


thanks,

Takashi
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/