linux-kernel - Re: [PATCH 3/4] Bug Fix drivers/pci/intel-iommu.c: convert paddr to correct DMA pfn

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <1249456989.9324.339.camel@macbook.infradead.org>
Date:	Wed, 05 Aug 2009 08:23:09 +0100
From:	David Woodhouse <dwmw2@...radead.org>
To:	Fenghua Yu <fenghua.yu@...el.com>
Cc:	Tony Luck <tony.luck@...el.com>, iommu@...ts.linux-foundation.org,
	linux-ia64@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 3/4] Bug Fix drivers/pci/intel-iommu.c: convert paddr
 to correct DMA pfn

On Tue, 2009-08-04 at 15:10 -0700, Fenghua Yu wrote:
> When calling domain_pfn_mapping(), paddr should be converted to DMA pfn
> correctly instead just shift by VTD_PAGE_SHIFT.
> 
> This issue causes kernel panic on PAGE_SIZE>VTD_PAGE_SIZE platforms e.g. ia64
> platforms.
> 
> Signed-off-by: Fenghua Yu <fenghua.yu@...el.com>

Using the word 'alignment' somewhere in the above commit would have
confused me a lot less -- I got most of the way through composing a mail
asking how this patch wasn't a no-op, before I spotted it.

An alternative would be to align the size to DMA pages? Would that make
the sg case easier? 

(Thanks for fixing this, btw)

-- 
dwmw2

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/