[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20090805081346.GA4983@console-pimps.org>
Date: Wed, 5 Aug 2009 09:13:46 +0100
From: Matt Fleming <matt@...sole-pimps.org>
To: Dave Airlie <airlied@...il.com>
Cc: Ingo Molnar <mingo@...e.hu>,
Linus Torvalds <torvalds@...ux-foundation.org>,
Benjamin Herrenschmidt <benh@...nel.crashing.org>,
Paul Mackerras <paulus@...ba.org>,
Steven Rostedt <rostedt@...dmis.org>,
linux-kernel@...r.kernel.org, Dave Jones <davej@...emonkey.org.uk>
Subject: Re: Please revert fc4c73554c9d93b3e495f2f7acae1323b0d5db84. Re:
[PATCH 1/2] ftrace: Fix the conditional that updates $ref_func
On Wed, Aug 05, 2009 at 05:13:33PM +1000, Dave Airlie wrote:
> On Fri, Jul 24, 2009 at 2:16 AM, Matt Fleming<matt@...sole-pimps.org> wrote:
> > Fix the conditional that checks if we already have a $ref_func and that
> > the new function is weak. The code as previously checking whether either
> > condition was false, and we really need to only update $ref_func is both
> > cconditions are false.
> >
>
> This breaks the powerpc build on Fedora.
>
> When building on ppc64 this commit causes the links of drivers/hwmon/lm93.o
> to fail.
>
> It introduces an undefined symbol
> U .LM93_IN_FROM_REG
>
> that isn't produced when this patch is reverted
>
> This was found when the Fedora kernel failed to build when I pulled in
> -rc5-git3.
>
> can be seen at the end of:
> http://koji.fedoraproject.org/koji/getfile?taskID=1582002&name=build.log
>
> So can we revert this (at this stage in -rc5 or maybe fix it).
>
> Dave.
>
Eek! So the patch actually causes recordmcount.pl to remove
LM_IN_FROM_REG from the object file? Sorry about that. That is not at
all something I would ever expect to happen. I'll see if I can recreate
this and try figure out what is going on.
Thanks for the report.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists