linux-kernel - Re: [PATCH 1/2] ds2760: switch to new dev_pm

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <200908051657.49810.elendil@planet.nl>
Date:	Wed, 5 Aug 2009 16:57:47 +0200
From:	Frans Pop <elendil@...net.nl>
To:	Daniel Mack <daniel@...aq.de>
Cc:	linux-kernel@...r.kernel.org, daniel@...aq.de,
	szabolcs.gyurko@....hu, mreimer@...p.net, cbou@...l.ru
Subject: Re: [PATCH 1/2] ds2760: switch to new dev_pm_ops

Daniel Mack wrote:
> +static struct dev_pm_ops ds2760_battery_pm_ops = {
> +       .suspend        = ds2760_battery_suspend,
> +       .resume         = ds2760_battery_resume,
> +};

Just to make sure...

Have you followed the earlier discussions on dev_pm_ops conversions and 
are you aware that if done like this the driver no longer supports 
hibernation?

If omitting hibernation is intentional, it should probably be justified in 
the commit log.

See http://lkml.org/lkml/2009/7/25/118 for background.

Same goes for your patch for w1_gpio of course.

Cheers,
FJP
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/