linux-kernel - Re: [PATCH 1/1] XFS: xfs_iformat realtime device target pointer check

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20090805151750.GA16080@infradead.org>
Date:	Wed, 5 Aug 2009 11:17:50 -0400
From:	Christoph Hellwig <hch@...radead.org>
To:	Ramon de Carvalho Valle <ramon@...esecurity.org>
Cc:	Eric Sandeen <sandeen@...deen.net>,
	Christoph Hellwig <hch@...radead.org>,
	linux-kernel@...r.kernel.org, mszeredi@...ell.com, hch@....de,
	xfs@....sgi.com
Subject: Re: [PATCH 1/1] XFS: xfs_iformat realtime device target pointer
	check

On Tue, Aug 04, 2009 at 03:51:38PM -0300, Ramon de Carvalho Valle wrote:
> The xfs_iformat function does not check if the realtime device target pointer
> is valid when the XFS_DIFLAG_REALTIME flag is set on the ondisk inode
> structure.

Same as Eric I don't think there's much of a point renumbering the error
cases.  Instead I'll do another patch with a couple of cleanups in this
function replacing all the numbers with short alphabetic tags.

I don't really see the point of printing the flags either, if we have
this bit flipped it's pretty clear that we had random corruption of this
dinode.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/