linux-kernel - Re: [PATCH 2/2] sound: make OSS device number claiming optional

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Thu, 06 Aug 2009 01:52:26 +0900
From:	Tejun Heo <teheo@...e.de>
To:	Alan Cox <alan@...rguk.ukuu.org.uk>
Cc:	Greg KH <greg@...ah.com>, Al Viro <viro@....linux.org.uk>,
	Takashi Iwai <tiwai@...e.de>,
	Linux Kernel <linux-kernel@...r.kernel.org>,
	cguthrie@...driva.org
Subject: Re: [PATCH 2/2] sound: make OSS device number claiming optional

Alan Cox wrote:
>> I don't see how I would be able to achieve the latter with one liner.
>> Can you please elaborate a little bit?
> 
> It depends how much of a hurry you are in, but for the mainstream we can
> do this
> 
> 1.	Make soundcore also issue the request_module() as if the char
> minor was unclaimed. Mark the old one as obsolete
> 
> 2.	Wait a year while people adjust their scripts to trigger on the
> char event instead (and fix the ordering bits for ALSA if the soundcore
> docs are still valid on that)
> 
> 3.	Apply a patch which makes ALSA use char dev allocation directly
> for its OSS devices and dumps out soundcore, remove soundcore and switch
> any other code using it.

It's quite difficult to think that those now mostly unused module
alises are worth full year of waiting and careful coordination.  I
think we're chasing a non-issue here.  If it really matters, I'll try
to teach chrdev about alternative module alises.

If you think the above is a good solution, how about the following?

1. Merge the weird switch thing and the extra standard chrdev module
   alias patch

2. Add to feature-removal that snd-slot/service-* are going away in a
   year along with the weird switches.  This allows people who wish to
   try or switch in the meantime to do so.

3. After a year, drop module loading related code from sound_core
   along with the weird config option and kernel parameter.

In the end, the only choice we have to make is whether to keep
snd-slot/service-* aliases.  If we're gonna (I don't see why tho), the
cleanest way would be to teach chrdev about aliases.  If not, the best
way is to add a switch so that it can be phased out gradually.

Thanks.

-- 
tejun
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/